| Age | Commit message (Collapse) | Author |
|---|
|
|
|
|
|
There are many objects declared as final but not defined as final.
|
|
|
|
|
|
Reading from NautilusFile might not not give correct results since Its info might not be loaded.
Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/3514
|
|
This follows what is used in other modern code bits, such as grid and
list view styling. It will also slightly help with porting to Blueprint
as there is an (unreported) bug of replacing the template class name in
other properties with "template".
|
|
|
|
Both, searching content and searching recursively, depend on the
location and on a preference. NautilusQuery already handles the
search location, so extend setting a new location to also handle
these settings.
Provide update functions to keep listening to setting changes
in query-editor. This prevents changing queries already passed
to search providers.
|
|
Allows to remove some usages of NautilusQuery.
|
|
This fixes issues with search tags on small windows. The highlighted
filter button combined with highlighted tags in the search popover
are the replacement.
|
|
|
|
Uses tag cloud instead of toggle buttons. Also adds a button for
content-only search, but keep it hidden as the search backend doesn't
support this yet. It matches the latest mockup at [1].
[1] https://gitlab.gnome.org/Teams/Design/app-mockups/-/blob/master/files/files-search-filters-aday.png
Co-authored-by: Anuraag Reddy Patllollu <anuraagreddy74@gmail.com>
|
|
|
|
Popover always updates the setting, use it from there. This is in
preparation of removing the query from the search popover
|
|
|
|
|
|
I originially did this to work around crashes that I later fixed,
but it is nicer anyway, so here it is.
|
|
|
|
|
|
This avoid throwing away search when copy pasting the same text or
when just adding a space to the start or end of the search text.
|
|
|
|
Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/3734
|
|
Already done by nautilus_query_editor_set_query()
|
|
|
|
|
|
info popover
Make the button to have a pill shape and align it to the center.
Generally status pages (the popover uses an AdwStatusPage) that
have buttons have this same design pattern.
|
|
Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/3524
|
|
This call will be cancelled when the editor is disposed. It should
not use the editor reference until it verifies that it wasn't
cancelled.
|
|
The popover now displays information when a folder is not indexed or
contains subfolders that are not indexed.
|
|
The popover now displays information when a folder is is a remote or an
external drive.
|
|
The original design for providing search information used a banner,
which does not align with modern conventions. This commit introduces a
new popover to display the same information inside an adwaita status
page
|
|
It's going to be replaced with a new Network view.[0]
For now this removes only the direct support in nautilus code proper.
The code imported from GtkPlacesView is kept to be recycled for a new
purpose.
[0] https://gitlab.gnome.org/GNOME/nautilus/-/issues/2785
|
|
- renamed assets from generic devkit names to nautilus specific names
- updated folder-search, external-link and cancel-operation with newer assets
- added network-computer symbolic for future use in the sidebar
|
|
Closes https://gitlab.gnome.org/GNOME/nautilus/-/issues/3013
|
|
As per design mockups. The search original icon is going to be used for
a new button which opens the global search mode, and as a prefix icon
is that mode.
Also update tooltip accordingly.
|
|
We have code which tries not to hide the search entry in case the user
opens it and, before inserting any query, decides to switch location.
This was introduced by commit 9ab3c5c7d7f7162193559ad643707dc1a2bc69fc
According to that commit message, it was restoring an old behavior that
was lost during a refactoring. I did not confirm this nor track the
original reason for this behavior, but, if I had to guess, I'd say it
comes from before "just-type" search was introduced. Otherwise, why go
to the trouble of keeping the search entry visible when you can just
type anyway?
I see no reason to assume the location change means they want to search
another location. They may have just recalled the exact path they were
looking for, so they lost the reason to search.
Anyway, this behavior is not working at all in recent versions. Not
sure when it stopped working, but apparently nobody has missed it.
Least this dead code interfere with the upcoming global search mode,
let's remove it.
|
|
We have been hitting warnings about NULL queries when doing
global searches, and this was the cause.
There is no good reason not to create a query, even if we are
not going to use it. Fix this before we make global search
more prominent.
|
|
We have an idle callback to deal with search text changes while
avoiding performance impact. We also freeze this completely if
the text changes are done programatically and not from user
typing.
But the idle callback is also responsible for hiding the clear
icon, which means we don't hide it if the entry is cleared
programatically (e.g. when leaving search using the Escape key
or the toggle button in the headerbar).
Since there is no performance cost to changing this visibility
of the child widget, we can just move this code to the synch
hanlder, before the change_frozen interrupt.
|
|
This conjunction makes no sense and might even lead to NULL pointer
dereference. This bug has been introduced just after the GTK4 port,
by commit 45c77d24669519bab75f2ae59926fcad0c8a7d53
Just make it a disjunction. This allows the clear button to correctly
hide when the user clear the text.
|
|
Use header capitalization, make tooltips short and change
the "Show operations" tooltip from nautilus-progress-indicator
so it can be more descriptive.
https://developer.gnome.org/hig/patterns/feedback/tooltips.html
|
|
This property is meant to be used only as a "socket" for the slot to set
the current location, for use in new queries. This is used internally
and, as such, it makes no sense to expose a getter.
The location being searched should be obtained from the query itself,
not the query editor. For that we have a get_query(), and the query
parameter in the ::changed signal.
|
|
The only use case for reading it is in order to get the location.
This can be obtained from the query instead, which is more
convenient to use after the last commit.
|
|
|
|
Change the `focus-search` action behavior to select all text when
a search refocusing action occurs so it's easier to type a new query.
Fixes https://gitlab.gnome.org/GNOME/nautilus/-/issues/2819
|
|
We trigger search after a short time interval after the user stops
typing, as a performance saving measure.
To implement that behaviour, we need to ignore text changes that
are done programatically and not by the user typing. In that case,
we don't setup the timer that triggers the search.
But in that case we also don't clear a previously set timer. Although
the previous commit has already fixed the visible effects of this bug,
the timed callback is still called, which may cause other unknown bugs.
So, let's always clear the timer when the search text changes, even
if programatically, such as when clearing the text when closing search.
Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/2875
|
|
With the changes done in the previous commits, the Tracker search
engine can take quite a pounding without breaking a sweat. Worrying
about spamming search engines is no longer a concern with queries
done the right way, so we do not need to artificially delay search.
The goal is that search feels responsive even to a fast typist.
Since this delay also applied to showing the search entry after
starting type-to-search, this also fixes the apparent stall when
one started typing.
|
|
Acc. HIG, all controls from headerbars must have a tooltip.
https://developer.gnome.org/hig/patterns/feedback/tooltips.html
Fixes https://gitlab.gnome.org/GNOME/nautilus/-/issues/2754
|
|
Replace with gtk_widget_set_visible() or gtk_window_present()
In some cases we use gtk_widget_show() unnecessarily because
widgets are visible by default
|
|
The search bar from the main window doesn't have a placeholder,
which the HIG generally requires.
Add the necessary placeholder.
Fixes https://gitlab.gnome.org/GNOME/nautilus/-/issues/2698
|
