| Age | Commit message (Collapse) | Author |
|---|
|
|
|
|
|
There are many objects declared as final but not defined as final.
|
|
|
|
|
|
Explicitly state which fields of the GActionEntry to fill. Improves
readability and fixes missing field initializers warnings.
|
|
We wait for ::finished to release the application hold.
NautilusProgressInfo emits this signal in a idle callback. But if it
gets destroyed in the meantime, the idle source is removed. As a
result, the ::finish signal never gets emitted and we keep holding the
application forever.
So, keep it alive while we wait for the ::finished signal.
|
|
It’s identical to gtk_window_is_active() as far as we are concerned.
Also, it's gone in GTK4.
|
|
The notification is shown when all operations are completed and Nautilus doesn't
have a focus. It says that "All file operations have been successfully completed".
This is shown also when some errors were skipped. So the word "successfully"
is a bit misleading. Let's drop that word from the notification.
Relates: https://gitlab.gnome.org/GNOME/nautilus/-/issues/1953
|
|
On completion of long file transfer operation. We currently show a
notification on completion of file transfer only if there are no open
windows.
To make Files more intuitive show all operations completed notification
even if there are open windows but none of them has focus.
Closes https://gitlab.gnome.org/GNOME/nautilus/-/issues/998
|
|
According to `g_list_length()` API documentaion: "To check whether
the list is non-empty, it is faster to check list against NULL."
Checking `GList`s against `NULL` is already common in this codebase.
Weed out the few checks of `g_list_length()` against `0` or `< 1`.
Closes https://gitlab.gnome.org/GNOME/nautilus/issues/241
|
|
This patch reduces the number of macros used to define the type,
by means of the macro G_DECLARE*, and improves the readability of code.
https://bugzilla.gnome.org/show_bug.cgi?id=780680
|
|
And make the style of Nautilus the same for all files.
Hopefully we can fix all the style issues we can find in the next days,
so expect a little of movement on this.
https://bugzilla.gnome.org/show_bug.cgi?id=770564
|
|
And fix make distcheck.
Although libnautilus-private seem self contained, it was actually
depending on the files on src/ for dnd.
Not only that, but files in libnautilus-private also were depending on
dnd files, which you can guess it's wrong.
Before the desktop split, this was working because the files were
distributed, but now was a problem since we reestructured the code, and
now nautilus being a library make distcheck stop working.
First solution was try to fix this inter dependency of files, but at
some point I realized that there was no real point on splitting some of
those files, because for example, is perfectly fine for dnd to need to
access the window functions, and it's perfectly fine for the widgets
in the private library to need to access to all dnd functions.
So seems to me the private library of nautilus is somehow an artificial
split, which provides more problems than solutions.
We needed libnautilus-private to have a private library that we could
isolate from extensions, but I don't think it worth given the problems
it provides, and also, this not so good logical split.
Right now, since with the desktop split we created a libnautilus to be
used by the desktop part of nautilus, extensions have access to all
the API of nautilus. We will think in future how this can be handled if
we want.
So for now, merge the libnautilus-private into src, and let's rethink
a better logic to split the code and the private parts of nautilus than
what we had.
Thanks a lot to Rafael Fonseca for helping in get this done.
https://bugzilla.gnome.org/show_bug.cgi?id=765543
|
|
GtkStatusIcon is deprecated as of GTK+ 3.14.
The progress persistence handler still uses deprecated status icons
alongside notifications.
The fix is to remove status icon support and use notifications
exclusively. Persistence support is expected in environments where
Nautilus is used, making status icons unnecessary.
https://bugzilla.gnome.org/show_bug.cgi?id=762243
|
|
Vim and emacs modelines are used to specify some of the code style in the code.
However, this is misleading and poorly supported since nautilus had a mix of
code style for some time.
Also, the mode lines doesn't specify the whole code style, so we will need to
use a different tool as well to specify the whole code style.
For that, we can just use a different tool for everything.
So remove the mode lines, and in a short future we will reestyle the nautilus
code to have a single code style, and use a tool like editorconfig to specify
the whole code style.
|
|
In Nautilus, notifications are sent using GApplication functions and are not
tracked. This leads to notifications that are not being cleared when Nautilus is
closed. In order to fix this, sending and withdrawing notifications should be
done with the methods of NautilusApplication. These methods automatically track
and clear them when the application is shutdown.
Replace GApplication functions for sending and withdrawing notifications with
corresponding NautilusApplication functions.
https://bugzilla.gnome.org/show_bug.cgi?id=763129
|
|
Now operations reside in the toolbar, in form of a button with
a popover. In this way we avoid to have a nautilus window hanging
around for it.
When no nautilus window is open, the persistence handlers of nautilus
are enough. This use a notification if the server supports it or
a systray icon in case it doesn't.
|
