| Age | Commit message (Collapse) | Author |
|---|
|
|
|
|
|
Remove indirect inclusions by replacing includes with forward
declarations where possible. This should provide a minor speed
up in compilation times.
|
|
|
|
|
|
The single pie for multiple operations has been too vague and not very
useful when dealing with multiple operations.
Implement the design produced from https://gitlab.gnome.org/Teams/Design/app-mockups/-/issues/89
Closes https://gitlab.gnome.org/GNOME/nautilus/-/issues/838
|
|
The operations button will be replaced by a short sidebar list
in the following commits. The sidebar pie is now useless.
|
|
Now that the progress indicator is in the bottom bar of the
toolbarview, we can simply bind our reveal property to show and
hide the progress indicator.
|
|
And restyle to cover the whole bar and open popover to the end.
|
|
Provide a widget name and shorten a class.
Also remove class which has been unused since 610c991ca79ad53a77effb32e67eb79341160b2b
|
|
There is no need to call should_show_progress_info() on elements of
a list that's already been filtered by should_show_progress_info().
should_hide_operations_button() doesn't call it but has the exact
same condition.
While at it, modernize the touched function definitions and mark
should_show_progress_info() to be inlined in its now-unique caller.
|
|
With g_signal_connect_object(), there is no need for manual
disconnect on destruction.
|
|
When a long-running (>=2 seconds) operation completes, we show a toast
in the active window, with possibly a button to open the destination.
For short operations the only feedback we have is when the operation
adds items from the folder that's currently being viewed, in which
case those added items are selected and scrolled into (if needed).
But if the destination isn't being viewed, and the operation completes
in less than 2 seconds, there's no visual feedback that the operation
has happened.
This happens because we are only connecting to "finished" signal on
operations which we estimate to take longer than 2 seconds. Indeed,
every time we update the progress indicator/operations popover, we
disconnect and reconnect signals.
Let's connect the signals only once, when the operation info is added,
and let's do it regardless of its estimated duration. Instead, let's
check how long the operation took before showing the notification;
this allows the window to decide not to show any notification if the
operation was short and the destination is being viewed, which is
the case where we already have adequate visual feedback and a toast
would only add noise.
Fixes https://gitlab.gnome.org/GNOME/nautilus/-/issues/267
|
|
Replace gtk_widget_get_allocated_(width/height) and
gtk_widget_get_allocation with gtk_widget_get_(height/width).
|
|
And set child property to NULL before calling it for bin-like
widgets.
Resolves https://gitlab.gnome.org/GNOME/nautilus/-/issues/2418
|
|
Replace with gtk_widget_set_visible() or gtk_window_present()
In some cases we use gtk_widget_show() unnecessarily because
widgets are visible by default
|
|
If the user cancels an operation and closes the window, Files crashes.
This happens because disconnect_progress_infos() does not disconnect
all signals taking *self as data, allowing use-after-free bugs.
Use g_signal_connect_object() to fix this implicitly.
Fixes https://gitlab.gnome.org/GNOME/nautilus/-/issues/1965
|
|
GtkStyleContext is deprecated in 4.10, use the corresponding
GtkWidget functions.
Also bump GTK version to use the new gtk_widget_get_color().
|
|
Same rationale as last commit, except this control is independent from
the window slot, so it doesn't require any property binding.
|
