| Age | Commit message (Collapse) | Author |
|---|
|
Each module's shutdown() should have been called in unload(), but
as we know, unload() never ended up getting called. Instead
call it during teardown()
Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/1971
|
|
|
|
Our modules never would reach the unload point anyways and GModule
doesn't actually unload the module, so let's remove anything related
to unloading to simplify.
Related: https://gitlab.gnome.org/GNOME/glib/-/issues/667
Related: https://gitlab.gnome.org/GNOME/glib/-/commit/72df62600d1ab473125b6e8beb998e71aa63701e
|
|
Oversight from https://gitlab.gnome.org/GNOME/nautilus/-/merge_requests/1319
where this was forgotten.
|
|
Explicitly clear modules from NautilusApplication, so they don't need
cleanup through the eel shutdown mechanism.
|
|
Newer compiler versions (i.e. Clang 15) failed to compile nautilus,
because the declaration did not match the function definition.
See: https://reviews.llvm.org/D122895
Fixes #2378
|
|
|
|
When NAUTILUS_DISABLE_PLUGINS == TRUE, do not load plugins.
Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/1779
|
|
And make the style of Nautilus the same for all files.
Hopefully we can fix all the style issues we can find in the next days,
so expect a little of movement on this.
https://bugzilla.gnome.org/show_bug.cgi?id=770564
|
|
And fix make distcheck.
Although libnautilus-private seem self contained, it was actually
depending on the files on src/ for dnd.
Not only that, but files in libnautilus-private also were depending on
dnd files, which you can guess it's wrong.
Before the desktop split, this was working because the files were
distributed, but now was a problem since we reestructured the code, and
now nautilus being a library make distcheck stop working.
First solution was try to fix this inter dependency of files, but at
some point I realized that there was no real point on splitting some of
those files, because for example, is perfectly fine for dnd to need to
access the window functions, and it's perfectly fine for the widgets
in the private library to need to access to all dnd functions.
So seems to me the private library of nautilus is somehow an artificial
split, which provides more problems than solutions.
We needed libnautilus-private to have a private library that we could
isolate from extensions, but I don't think it worth given the problems
it provides, and also, this not so good logical split.
Right now, since with the desktop split we created a libnautilus to be
used by the desktop part of nautilus, extensions have access to all
the API of nautilus. We will think in future how this can be handled if
we want.
So for now, merge the libnautilus-private into src, and let's rethink
a better logic to split the code and the private parts of nautilus than
what we had.
Thanks a lot to Rafael Fonseca for helping in get this done.
https://bugzilla.gnome.org/show_bug.cgi?id=765543
|
