| Age | Commit message (Collapse) | Author |
|---|
|
Since [1] GdkPixbuf isn't used anymore to read image information, so it
shouldn't be used to determine whether an image is supported. Instead
use the mime type's generic icon, which will result in some false
positives of formats not actually handled, but will work fine for common
formats.
[1] https://gitlab.gnome.org/GNOME/nautilus/-/commit/d24ccd35ceee75103fefa8ce5d4ed4c1facb9c63
|
|
For formats not supported by gexiv, such as svg or JPEGXL.
Fixes https://gitlab.gnome.org/GNOME/nautilus/-/issues/4136
|
|
Prepares this code to be reused in upcoming commit.
|
|
|
|
possible
|
|
GdkPixbuf was used to get the image type, width and height, all of which
are also provided by gexiv2, which is already used anyway.
|
|
This is done so now to keep the next commit diff readable.
|
|
|
|
These types are unknown to xdg-shared-mime-info.
|
|
|
|
|
|
This requires a library name change.
|
|
Per the docs, the files from get_model() are owned by the caller,
but image-properties assumes it owns the file. This doesn't cause
any problems now, but it could in the future.
|
|
Don't add container info if the info given by
gst_discoverer_info_get_stream_info() is not for containers.
We should be using gst_discoverer_info_get_container_streams() but it seems
to give null on the files I tried.
Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/3839
|
|
Without a correctly initialized GstDiscoverer, no locations can be
set, so return early if that is the case.
|
|
While the code is imported, indentions on the current files are a mess.
This makes it more difficult for contributors to get things right, so
incude these files in the uncrustify script and format them.
|
|
This changes the way sampling rate units get displayed, it will now append 'kHz' for values larger than 999Hz.
Additionally, this also includes a thousands separator for kHz for better presentation.
Fixes #3237
|
|
Convert the Exif datetime format to standard ISO time format.
Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/1170
|
|
Also rename a variable to avoid shadowing.
|
|
Fixes missing field initializers warnings.
|
|
A collection of simple fixes for comparison warnings.
|
|
|
|
Free the resources left over in the case of a cancellation which
was handeled in the previous commit.
|
|
Calling refresh_extension_model_pages() might cancel a pending
IO operation and free the ImagesPropertiesModel. Bailout after
being cancelled instead of using a freed data.
|
|
Handle the case where
gexiv2_metadata_try_get_tag_interpreted_string returns a null
pointer to avoid a crash.
Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/3138
|
|
Don't try to read the image orientation if the metadata is not ready.
|
|
We ask to append a failure message with NULL value, and then don't
actually append it because of the value being NULL. This makes no
sense, so fix it.
Despite that, in order to improve visuals, move the failure message
to the value and use an existing generic error string as title.
|
|
The properties extension no longer creates a widget, so it's no
longer a simple task of packing that widget into a window.
We never use that test program anyway; manual testing can and
should be performed in the main application.
|
|
Rather than displaying a broken page without any row.
|
|
|
|
GdkPixbuf is enough here.
|
|
|
|
nautilus-sendto is no longer maintained and never worked in
sandboxed environments. Remove and re-add using portal
See: https://gitlab.gnome.org/GNOME/nautilus/-/issues/928
|
|
gtk4-builder-tool tries to port uses of `can_focus` to `focusable`,
but in real code you generally don't need to set `focusable` - the
defaults are always sensible, and removing the explicit property
means less code without any behavior change.
|
|
Now that we have broken the API, remove compatibility typedefs
introduced in 7e2605c681d065e6b0a3d779c30b892932597991
Also update audio-video-properies to use the new symbols.
|
|
Now that gtk4 code is in place, enable build of audio-video-properties
again. Previously disabled in 9f8d4c9e111b972acedf1dfbdd83fcb3ca20e027
However, we must still disable tests for the time being, until we port
them away from gtk_main(), together with other tests already disabled
due to gtk4 by commit 388b2cbb09a2d19eb1b948c435d8bc7cb111149d
|
|
Use new functions and syntax. Minor code cleanup in order to
make debugging easier. GTK4 doesn't use border width, use margins
consistent with main properties page.
|
|
The new major version of the toolkit is a requirement to fix old issues and enable future enhancements.
Update symbols and adapt logic to API changes.
Update and simplify UI definitions.
Update local copy of places sidebar and places view.
Replace dependencies with their GTK4-compatible successors.
Make a minimum changes required to build and run, with known
regressions to be fixed in future commits.
For a detailed breakup of the changes, see the 36 commits-deep
log leading to d5763facb1e5045251171ed1273dca0859f3542f.
This is the main part of https://gitlab.gnome.org/GNOME/nautilus/-/issues/276
|
|
Also drop the slash separator, which is non-standard for geographical coordinates.
|
|
Not ported to GTK 4 yet. To speedup the port, disable the extension.
To be ported later.
|
|
Preparing for GTK4.
|
|
GTK discourages subclassing widgets.
The only reason we are subclassing here is to add struct fields. But we
don't need to subclass a widget for that. We don't even need to subclass
GObject. A plain data struct is enough.
|
|
Build log contains deprecation warnings for gexiv2 functions.
Replaced `gexiv2_metadata_has_tag()` with
`gexiv2_metadata_try_has_tag()` and `gexiv2_metadata_get_orientation()`
with `gexiv2_metadata_try_get_orientation()`
Closes: #2033
|
|
The build log contains warnings about deprecated gexiv2 functions. Let's
port to the new API, unpin exiv3 and gexiv2 dependencies in flatpak manifests
and bump the build dependency accordingly to get rid of the warnings.
|
|
Images with EXIF metadata can contain an orientation tag, which indicates the
image should be rotated. In the Image tab of the Properties dialog, swap the
width and height if the image is rotated by 90 or 270 degrees.
Fixes #1590.
|
|
There are some style issue since the last run. Let's run it again
before enabling style-check CI job.
|
|
"Frames per second" string in audio-video-properties tab was unavailable for translation.
To fix this, handle the string with g_dngettext() and allow for both singular and plural translation.
Closes https://gitlab.gnome.org/GNOME/nautilus/issues/990
|
|
‘framerate’ and ‘bitrate’ aren’t dictionary words; add a space to make
them ‘frame rate’ and ‘bit rate’ instead.
This makes them match the ‘sample rate’ string also in that file.
Signed-off-by: Philip Withnall <withnall@endlessm.com>
|
|
I was getting:
error: variable 'string' is used uninitialized whenever 'if' condition is
false [-Werror,-Wsometimes-uninitialized]
|
|
Add a bit more precision to the frames per second property.
Closes: #901
|
