summaryrefslogtreecommitdiff
path: root/drivers/staging/sm750fb
AgeCommit message (Collapse)Author
2026-02-07staging: sm750fb: Clean up variable namesChristine Ramacha
Variables in sm750_accel.c follow a mix of camelCase convention and Hungarian shorthands. Rename it to adhere to kernel's snake_case naming convention and improve readability. Signed-off-by: Christine Ramacha <christine.rv4573@gmail.com> Link: https://patch.msgid.link/20260204145107.5521-1-christine.rv4573@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-01-27staging: sm750fb: rename initParm to init_parmMadhumitha Sundar
The Linux kernel coding style prefers snake_case over CamelCase for variable names. Rename the 'initParm' member to 'init_parm' to comply with this standard. Signed-off-by: Madhumitha Sundar <madhuananda18@gmail.com> Link: https://patch.msgid.link/20260127121148.36632-1-madhuananda18@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-01-11staging: sm750fb: fix typo 'resetted' -> 'reset'Akiyoshi Kurita
Fix a typo in a comment. Signed-off-by: Akiyoshi Kurita <weibu@redadmin.org> Link: https://patch.msgid.link/20260103120824.1275574-1-weibu@redadmin.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-01-11staging/sm750fb: remove outdated TODO linesWilliam Hansen-Baird
The TODO lines about "checkpatch cleanup" and "kernel coding style" are no longer needed as all files conform to the kernel coding style, as verified with checkpatch.pl Note: checkpatch reports a false positive WARNING for sm750.c line 36 about missing const in static const char *g_fbmode[]. checkpatch suggests static const char * const g_fbmode[]. This was intentional, as the array is modified throughout the code, while the inner strings remain unchanged. Signed-off-by: William Hansen-Baird <william.hansen.baird@icloud.com> Link: https://patch.msgid.link/20251222212849.555571-2-william.hansen.baird@icloud.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2025-12-22staging: sm750fb: Rename CamelCase variable fixId to fix_idTim Wassink
The variable fixId violates the kernel coding style, which prefers snake_case for variable names. Rename it to fix_id to match the standard style. This is a coding style change only. Signed-off-by: Tim Wassink <timwassink.dev@gmail.com> Link: https://patch.msgid.link/20251221153102.38178-1-timwassink.dev@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2025-11-09staging: sm750fb: avoid chained assignment in setcolreg()Cristian Del Gobbo
Replace the chained assignment of red/green/blue with a temporary variable and braces. This keeps behavior identical while improving readability and satisfying checkpatch. No functional change intended. Signed-off-by: Cristian Del Gobbo <cristiandelgobbo87@gmail.com> Link: https://patch.msgid.link/20251102230139.1720-2-cristiandelgobbo87@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2025-11-09staging: sm750fb: align sm750_hw_cursor_set_size() argumentsCristian Del Gobbo
Align the continued arguments with the opening parenthesis to satisfy CodingStyle and checkpatch. No functional change intended. Signed-off-by: Cristian Del Gobbo <cristiandelgobbo87@gmail.com> Link: https://patch.msgid.link/20251102230139.1720-1-cristiandelgobbo87@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2025-10-13staging: sm750fb: rename camel case identifiersAhmet Sezgin Duran
Rename two identifiers from camel case to snake case, in order to follow kernel coding style. Changes: - Local variable `deCtrl` to `de_ctrl` - Function `deGetTransparency` to `de_get_transparency` Signed-off-by: Ahmet Sezgin Duran <ahmet@sezginduran.net> Link: https://lore.kernel.org/r/20250920155552.261976-1-ahmet@sezginduran.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2025-09-14staging: sm750fb: rename camel case variableAhmet Sezgin Duran
Rename regValue to reg_value to follow kernel coding style. Signed-off-by: Ahmet Sezgin Duran <ahmet@sezginduran.net> Link: https://lore.kernel.org/r/20250912162627.95010-1-ahmet@sezginduran.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2025-09-12staging: sm750fb: rename snake case variablesYiming Qian
Replaces CamelCase variable names with snake_case: - dprBase -> dpr_base - dpPortBase -> dp_port_base Signed-off-by: Yiming Qian <qianym1996@gmail.com> Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org> Link: https://lore.kernel.org/r/20250909060130.12919-3-qianym1996@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2025-09-12staging: sm750fb: remove unnecessary volatile qualifiersYiming Qian
The use of 'volatile' for memory-mapped I/O pointers is discouraged in the Linux kernel as per Documentation/process/volatile-considered-harmful.rst. This patch removes the unnecessary 'volatile' qualifiers from the lynx_accel struct members, improving code quality and maintainability. Signed-off-by: Yiming Qian <qianym1996@gmail.com> Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org> Link: https://lore.kernel.org/r/20250909060130.12919-2-qianym1996@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2025-07-24staging: sm750fb: fix CamelCase variable namingIgnacio Pena
Replace CamelCase variable 'Bpp' with lowercase 'bpp' to fix checkpatch warnings about improper variable naming convention. Signed-off-by: Ignacio Pena <ignacio.pena87@gmail.com> Link: https://lore.kernel.org/r/20250716181718.82227-1-ignacio.pena87@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2025-07-16staging: sm750fb: fix function parameter alignmentIgnacio Pena
Fix checkpatch warning about improper function parameter alignment in sm750_hw_cursor_set_pos function call. Signed-off-by: Ignacio Pena <ignacio.pena87@gmail.com> Link: https://lore.kernel.org/r/20250716053357.64711-1-ignacio.pena87@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2025-06-30staging: sm750fb: remove function pointer proc_setBLANKKisub Choe
Call a function based on sm750_dev->revid instead of using this indirection Signed-off-by: Kisub Choe <kisub.choe.0x1@gmail.com> Link: https://lore.kernel.org/r/aFWSSAcboBVi4ROh@zinc Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2025-06-19staging: sm750fb: rename 'hwCursor'Kisub Choe
Rename 'hwCursor' to 'hw_cursor' to conform with kernel style guidelines as reported by checkpatch.pl CHECK: Avoid CamelCase: <hwCursor> Signed-off-by: Kisub Choe <kisub.choe.0x1@gmail.com> Link: https://lore.kernel.org/r/20250618143342.6517-1-kisub.choe.0x1@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2025-05-21staging: sm750fb: rename `hw_sm750le_setBLANK`Eric Florin
Rename `hw_sm750le_setBLANK` to `hw_sm750le_set_blank` to conform with kernel style guidelines as reported by checkpatch.pl CHECK: Avoid CamelCase: <hw_sm750le_setBLANK> Signed-off-by: Eric Florin <ericflorin@google.com> Link: https://lore.kernel.org/r/b49d1a00628a3475fdfbff4055d8347d35a802a9.1747619816.git.ericflorin@google.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2025-05-21staging: sm750fb: rename `hw_sm750_setBLANK`Eric Florin
Rename `hw_sm750_setBLANK` to `hw_sm750_set_blank` to conform with kernel style guidelines as reported by checkpatch.pl CHECK: Avoid CamelCase: <hw_sm750_setBLANK> Signed-off-by: Eric Florin <ericflorin@google.com> Link: https://lore.kernel.org/r/e00a39ffba89e000fdf8dc277166297d995aa891.1747619816.git.ericflorin@google.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2025-05-21staging: sm750fb: rename `hw_sm750_setColReg`Eric Florin
Rename `hw_sm750_setColReg` to `hw_sm750_set_col_reg` to conform with kernel style guidelines as reported by checkpatch.pl CHECK: Avoid CamelCase: <hw_sm750_setColReg> Signed-off-by: Eric Florin <ericflorin@google.com> Link: https://lore.kernel.org/r/3d4bb87742eee4a6792bbdae893256f621ffffe6.1747619816.git.ericflorin@google.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2025-05-21staging: sm750fb: rename `hw_sm750_crtc_setMode`Eric Florin
Rename `hw_sm750_crtc_setMode` to `hw_sm750_crtc_set_mode` to conform with kernel style guidelines as reported by checkpatch.pl CHECK: Avoid CamelCase: <hw_sm750_crtc_setMode> Signed-off-by: Eric Florin <ericflorin@google.com> Link: https://lore.kernel.org/r/40d4a1f5b05bcb0eefdd787b9df329fceb96105e.1747619816.git.ericflorin@google.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2025-05-21staging: sm750fb: rename `hw_sm750_crtc_checkMode`Eric Florin
Rename `hw_sm750_crtc_checkMode` to `hw_sm750_crtc_check_mode` to conform with kernel style guidelines as reported by checkpatch.pl CHECK: Avoid CamelCase: <hw_sm750_crtc_checkMode> Signed-off-by: Eric Florin <ericflorin@google.com> Link: https://lore.kernel.org/r/546e9abb8eac1be75f47b51460ab69a5736d8a99.1747619816.git.ericflorin@google.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2025-05-21staging: sm750fb: rename `hw_sm750_output_setMode`Eric Florin
Rename `hw_sm750_output_setMode` to `hw_sm750_output_set_mode` to conform with kernel style guidelines as reported by checkpatch.pl CHECK: Avoid CamelCase: <hw_sm750_output_setMode> Signed-off-by: Eric Florin <ericflorin@google.com> Link: https://lore.kernel.org/r/32daa589cf80d2f6f67ed257aa9397128a5458d2.1747619816.git.ericflorin@google.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2025-05-21staging: sm750fb: rename `hw_sm750le_deWait`Eric Florin
Rename `hw_sm750le_deWait` to `hw_sm750le_de_wait` to conform with kernel style guidelines as reported by checkpatch.pl CHECK: Avoid CamelCase: <hw_sm750le_deWait> Signed-off-by: Eric Florin <ericflorin@google.com> Link: https://lore.kernel.org/r/0e5332f7758ad24cc5bca36671fd811c87881db7.1747619816.git.ericflorin@google.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2025-05-21staging: sm750fb: rename `hw_sm750_deWait`Eric Florin
Rename `hw_sm750_deWait` to `hw_sm750_de_wait` to conform with kernel style guidelines as reported by checkpatch.pl CHECK: Avoid CamelCase: <hw_sm750_deWait> Signed-off-by: Eric Florin <ericflorin@google.com> Link: https://lore.kernel.org/r/2d94a42ca51de9fddddb64f74e217dfb2e0c7d1c.1747619816.git.ericflorin@google.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2025-05-21staging: sm750fb: rename `hw_sm750_initAccel`Eric Florin
Rename `hw_sm750_initAccel` to `hw_sm750_init_accel` to conform with kernel style guidelines as reported by checkpatch.pl CHECK: Avoid CamelCase: <hw_sm750_initAccel> Signed-off-by: Eric Florin <ericflorin@google.com> Link: https://lore.kernel.org/r/3c84dccaf38161d6de6ff560d4f10bb3d344cc51.1747619816.git.ericflorin@google.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2025-05-01staging: sm750fb: rename sm750_hw_cursor_setData2Eric Florin
Rename sm750_hw_cursor_setData2 to sm750_hw_cursor_set_data2 to conform with kernel style guidelines as reported by checkpatch.pl CHECK: Avoid CamelCase: <sm750_hw_cursor_setData2> Signed-off-by: Eric Florin <ericflorin.kernel@gmail.com> Link: https://lore.kernel.org/r/af5080150498adf635be36e332a7ce7121692f93.1745982772.git.ericflorin.kernel@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2025-05-01staging: sm750fb: rename sm750_hw_cursor_setDataEric Florin
Rename sm750_hw_cursor_setData to sm750_hw_cursor_set_data to conform with kernel style guidelines as reported by checkpatch.pl CHECK: Avoid CamelCase: <sm750_hw_cursor_setData> Signed-off-by: Eric Florin <ericflorin.kernel@gmail.com> Link: https://lore.kernel.org/r/1ce4ddfd5ddf0443fd5a01ea5a4cb76a90e8cf30.1745982772.git.ericflorin.kernel@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2025-05-01staging: sm750fb: rename sm750_hw_cursor_setColorEric Florin
Rename sm750_hw_cursor_setColor to sm750_hw_cursor_set_color to conform with kernel style guidelines as reported by checkpatch.pl CHECK: Avoid CamelCase: <sm750_hw_cursor_setColor> Signed-off-by: Eric Florin <ericflorin.kernel@gmail.com> Link: https://lore.kernel.org/r/93717027d952d14d9b17f78e8440a734e4dc5d89.1745982772.git.ericflorin.kernel@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2025-05-01staging: sm750fb: rename sm750_hw_cursor_setPosEric Florin
Rename sm750_hw_cursor_setPos to sm750_hw_cursor_set_pos to conform with kernel style guidelines as reported by checkpatch.pl CHECK: Avoid CamelCase: <sm750_hw_cursor_setPos> Signed-off-by: Eric Florin <ericflorin.kernel@gmail.com> Link: https://lore.kernel.org/r/bf20fba915d2f0139a55ada29fcdefb9fdcbc1d6.1745982772.git.ericflorin.kernel@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2025-05-01staging: sm750fb: rename sm750_hw_cursor_setSizeEric Florin
Rename sm750_hw_cursor_setSize to sm750_hw_cursor_set_size to conform to kernel style guidelines as reported by checkpatch.pl CHECK: Avoid CamelCase: <sm750_hw_cursor_setSize> Signed-off-by: Eric Florin <ericflorin.kernel@gmail.com> Link: https://lore.kernel.org/r/c465a42743c4fef0853ffa7f7c304dc569592d3e.1745982772.git.ericflorin.kernel@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2025-04-25staging: sm750fb: change `enum dpms` to snake_caseEric Florin
Change the entries in `enum dpms` to snake_case in order to conform to kernel code styles as reported by checkpatch.pl CHECK: Avoid CamelCase: <crtDPMS_ON> CHECK: Avoid CamelCase: <crtDPMS_STANDBY> CHECK: Avoid CamelCase: <crtDPMS_SUSPEND> CHECK: Avoid CamelCase: <crtDPMS_OFF> Signed-off-by: Eric Florin <ericflorin.kernel@gmail.com> Link: https://lore.kernel.org/r/20250423040345.11323-1-ericflorin.kernel@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2025-04-25staging: sm750fb: remove irrelevant TODO lineRuben Wauters
As all code referencing USE_HW_I2C and USE_DVICHIP has now been deleted, this patch removes the TODO line referencing it. Signed-off-by: Ruben Wauters <rubenru09@aol.com> Link: https://lore.kernel.org/r/20250418151755.42624-5-rubenru09@aol.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2025-04-25staging: sm750fb: remove ddk750_hwi2cRuben Wauters
With the removal of ddk750_sii164.c, the functions in ddk750_hwi2c are now also unused. This patch removes them and the files they are in. Signed-off-by: Ruben Wauters <rubenru09@aol.com> Link: https://lore.kernel.org/r/20250418151755.42624-4-rubenru09@aol.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2025-04-25staging: sm750fb: remove ddk750_dviRuben Wauters
This file and the code present was unused in the whole driver, therefore this patch removes the file and unused reference to the header. Signed-off-by: Ruben Wauters <rubenru09@aol.com> Link: https://lore.kernel.org/r/20250418151755.42624-3-rubenru09@aol.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2025-04-25staging: sm750fb: Remove ddk750_sii164Ruben Wauters
Removes unused functions and files ddk750_sii164. Functions were used in ddk750_dvi.c, which is itself unused. Removal will be in the second patch in the series. Signed-off-by: Ruben Wauters <rubenru09@aol.com> Link: https://lore.kernel.org/r/20250418151755.42624-2-rubenru09@aol.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2025-04-18staging: sm750fb: clean-up `else`-blocksEric Florin
Clean-up `else`-blocks in `hw_sm750_map` that occur after `if`-blocks that terminate function execution. Signed-off-by: Eric Florin <ericflorin.kernel@gmail.com> Link: https://lore.kernel.org/r/20250418035023.27067-1-ericflorin.kernel@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2025-04-15staging: sm750fb: change sii164ClearInterrupt to snake_caseRichard Akintola
Change camelCase function name sii164ClearInterrupt to sii164_clear_interrupt in order to conform to kernel code styles as reported by checkpatch.pl CHECK: Avoid camelCase: <sii164ClearInterrupt> Signed-off-by: Richard Akintola <princerichard17a@gmail.com> Link: https://lore.kernel.org/r/549b645b265edcb793458a534427f75f0ea343c4.1744105389.git.princerichard17a@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2025-04-15staging: sm750fb: change sii164CheckInterrupt to snake_caseRichard Akintola
Change camelCase function name sii164CheckInterrupt to sii164_check_interrupt in order to conform to kernel code styles as reported by checkpatch.pl CHECK: Avoid camelCase: <sii164CheckInterrupt> Signed-off-by: Richard Akintola <princerichard17a@gmail.com> Link: https://lore.kernel.org/r/c5c01f1840ca37c24fcca7bff4b09adba37c3a7f.1744105389.git.princerichard17a@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2025-04-15staging: sm750fb: change sii164IsConnected to snake_caseRichard Akintola
Change camelCase function name sii164IsConnected to sii164_is_connected to conform to kernel code styles as reported by checkpatch.pl CHECK: Avoid camelCase: <sii164IsConnected> Signed-off-by: Richard Akintola <princerichard17a@gmail.com> Link: https://lore.kernel.org/r/05de0fb87ed53015cd01ef9460996597ef1e09c8.1744105389.git.princerichard17a@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2025-04-15staging: sm750fb: change sii164EnableHotPlugDetection to snake_caseRichard Akintola
Change camelCase function name sii164EnableHotPlugDetection to sii164_enable_hot_plug_detection and it's parameter enableHotPlug to enable_hot_plug to conform to kernel code styles as reported by checkpatch.pl CHECK: Avoid camelCase: <sii164EnableHotPlugDetection> Signed-off-by: Richard Akintola <princerichard17a@gmail.com> Link: https://lore.kernel.org/r/04907f753bc0d1a2b2095ffba1d066516520fbb8.1744105389.git.princerichard17a@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2025-04-15staging: sm750fb: change sii164GetChipString to snake_caseRichard Akintola
Change camelCase function name sii164GetChipString to sii164_get_chip_string to conform to kernel code styles as reported by checkpatch.pl CHECK: Avoid camelCase: <sii164GetChipString> Signed-off-by: Richard Akintola <princerichard17a@gmail.com> Link: https://lore.kernel.org/r/08eb6104c7b82aea32796163421a7e795d3d8964.1744105389.git.princerichard17a@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2025-04-15staging: sm750fb: change sii164SetPower to snake_caseRichard Akintola
Change camelCase function name sii164SetPower to sii164_set_power to conform to kernel code styles as reported by checkpatch.pl CHECK: Avoid camelCase: <sii164SetPower> Signed-off-by: Richard Akintola <princerichard17a@gmail.com> Link: https://lore.kernel.org/r/90f9842254eb83c2dc19abcf5072aab9549026a9.1744105389.git.princerichard17a@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2025-04-15staging: sm750fb: change sii164ResetChip to snake_caseRichard Akintola
Change camelCase function name sii164ResetChip to sii164_reset_chip to conform to kernel code styles as reported by checkpatch.pl CHECK: Avoid camelCase: <sii164ResetChip> Signed-off-by: Richard Akintola <princerichard17a@gmail.com> Link: https://lore.kernel.org/r/0974eb17fa67b707e8d2972668da4d8a692a9702.1744105388.git.princerichard17a@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2025-04-07staging: sm750fb: fix casing style on getDeviceIDJustin Cromer
Fixes camel casing for getDeviceID function. This includes an update to the internal function variable 'deviceID' as it's relevant, needs updating, and is clearly scoped to the small function. Signed-off-by: Justin Cromer <justincromer@gmail.com> Link: https://lore.kernel.org/r/Z-CPQ7dGuTBZ3sWv@fedora Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2025-02-19staging: sm750fb: fix checkpatch warning architecture specific defines ↵Michael Anckaert
should be avoided Replace architecture-specific defines with CONFIG_X86 checks to improve portability and adhere to kernel coding standards. Fixes checkpatch warning: - CHECK: architecture specific defines should be avoided. Changes made: - Using CONFIG_X86 instead of i386 and x86. Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de> Signed-off-by: Michael Anckaert <michael.anckaert@gmail.com> Link: https://lore.kernel.org/r/Z6x0GEM5sxcruYlS@michael-devbox Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2024-11-10staging: sm750fb: Remove TODO contact informationDominik Karol Piątkowski
Remove contact information from TODO file, as it is redundant and can get stale easily. Signed-off-by: Dominik Karol Piątkowski <dominik.karol.piatkowski@protonmail.com> Link: https://lore.kernel.org/r/20241107172908.95530-3-dominik.karol.piatkowski@protonmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2024-01-23video/nomodeset: Select nomodeset= parameter with CONFIG_VIDEOThomas Zimmermann
Enable support for nomodeset= parameter via CONFIG_VIDEO. Both, DRM and fbdev, already select this option. Remove the existing option CONFIG_VIDEO_NOMODESET. Simplifies the Kconfig rules. Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> Link: https://patchwork.freedesktop.org/patch/msgid/20240118090721.7995-4-tzimmermann@suse.de
2023-11-29staging/sm750fb: Initialize fb_ops with fbdev macrosThomas Zimmermann
Initialize all instances of struct fb_ops with fbdev initializer macros for framebuffers in I/O address space. Set the read/write, draw and mmap callbacks to the correct implementation and avoid implicit defaults. Also select the necessary helpers in Kconfig. Fbdev drivers sometimes rely on the callbacks being NULL for a default I/O-memory-based implementation to be invoked; hence requiring the I/O helpers to be built in any case. Setting all callbacks in all drivers explicitly will allow to make the I/O helpers optional. This benefits systems that do not use these functions. Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com> Cc: Teddy Wang <teddy.wang@siliconmotion.com> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: linux-staging@lists.linux.dev Reviewed-by: Javier Martinez Canillas <javierm@redhat.com> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Link: https://patchwork.freedesktop.org/patch/msgid/20231127131655.4020-27-tzimmermann@suse.de
2023-11-29staging/sm750fb: Declare fb_ops as constantThomas Zimmermann
Split up lynxfb_ops and declare each as constant. The fb_ops instance used to be modified while initializing the driver. It is now constant and the driver picks the correct instance, depending on the settings for acceleration and cursor support. Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com> Cc: Teddy Wang <teddy.wang@siliconmotion.com> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: linux-staging@lists.linux.dev Acked-by: Javier Martinez Canillas <javierm@redhat.com> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Link: https://patchwork.freedesktop.org/patch/msgid/20231127131655.4020-26-tzimmermann@suse.de
2023-10-21staging: sm750fb: Remove unused return variable in program_mode_registers()Dorcas AnonoLitunya
Drops variable ret as it is unused in the code. This therefore modifies the return type of program_mode_registers() to void from int since the return value is being ignored in all function calls. This improves code readability and maintainability. Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Dorcas AnonoLitunya <anonolitunya@gmail.com> Link: https://lore.kernel.org/r/20231019101348.22076-3-anonolitunya@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2023-10-17Staging: sm750fb: Rename ddk750_setModeTimingDorcas AnonoLitunya
Rename function ddk750_setModeTiming to ddk750_set_mode_timing. This patch affects three files as the function is imported to other external files. This follows snakecase naming convention and ensures a consistent naming style throughout the file. Issue found by checkpatch. Mutes the following checkpatch error: CHECK:Avoid CamelCase: <ddk750_setModeTiming> Signed-off-by: Dorcas AnonoLitunya <anonolitunya@gmail.com> Link: https://lore.kernel.org/r/20231016201434.7880-6-anonolitunya@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>