summaryrefslogtreecommitdiff
path: root/drivers/net
diff options
context:
space:
mode:
authorMaxime Chevallier <maxime.chevallier@bootlin.com>2026-02-05 10:23:05 +0100
committerJakub Kicinski <kuba@kernel.org>2026-02-12 17:44:55 -0800
commit6248f3dc4ec536163bf8e1761f3c08d6f31c3cfe (patch)
treee0b8f117f3f4c2776ae1e5dbfefa3948f5c5a5cb /drivers/net
parent056166710543a01ebcf25449bb462388e44b6ef6 (diff)
net: phy: phy_port: Cleanup the of-parsing logic for phy_port
We don't need to maintain a mediums bitfield, let's drop it and drop a bogus check for empty mediums, as we already check it above. Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com> Reviewed-by: Christophe Leroy (CS GROUP) <chleroy@kernel.org> Link: https://patch.msgid.link/20260205092317.755906-3-maxime.chevallier@bootlin.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'drivers/net')
-rw-r--r--drivers/net/phy/phy_port.c9
1 files changed, 2 insertions, 7 deletions
diff --git a/drivers/net/phy/phy_port.c b/drivers/net/phy/phy_port.c
index ec93c8ca051e..a269e9ea12c4 100644
--- a/drivers/net/phy/phy_port.c
+++ b/drivers/net/phy/phy_port.c
@@ -53,7 +53,7 @@ struct phy_port *phy_of_parse_port(struct device_node *dn)
enum ethtool_link_medium medium;
struct phy_port *port;
const char *med_str;
- u32 pairs = 0, mediums = 0;
+ u32 pairs = 0;
int ret;
ret = fwnode_property_read_string(fwnode, "media", &med_str);
@@ -85,17 +85,12 @@ struct phy_port *phy_of_parse_port(struct device_node *dn)
return ERR_PTR(-EINVAL);
}
- mediums |= BIT(medium);
-
- if (!mediums)
- return ERR_PTR(-EINVAL);
-
port = phy_port_alloc();
if (!port)
return ERR_PTR(-ENOMEM);
port->pairs = pairs;
- port->mediums = mediums;
+ port->mediums = BIT(medium);
return port;
}