diff options
| author | Janne Grunau <j@jannau.net> | 2025-12-31 10:42:12 +0100 |
|---|---|---|
| committer | Lee Jones <lee@kernel.org> | 2026-01-22 14:23:20 +0000 |
| commit | 414f65d6736342c77d4ec5e7373039f4a09250dd (patch) | |
| tree | c9bb80c63e1bb43648b6f74acc22e35c58d838db /drivers/mfd | |
| parent | e46de99c91de2eb1c6517a9be6934086cefb85b8 (diff) | |
mfd: macsmc: Initialize mutex
Initialize struct apple_smc's mutex in apple_smc_probe(). Using the
mutex uninitialized surprisingly resulted only in occasional NULL
pointer dereferences in apple_smc_read() calls from the probe()
functions of sub devices.
Cc: stable@vger.kernel.org
Fixes: e038d985c9823 ("mfd: Add Apple Silicon System Management Controller")
Signed-off-by: Janne Grunau <j@jannau.net>
Reviewed-by: Sven Peter <sven@kernel.org>
Reviewed-by: Neal Gompa <neal@gompa.dev>
Link: https://patch.msgid.link/20251231-macsmc-mutex_init-v2-1-5818c9dc9b29@jannau.net
Signed-off-by: Lee Jones <lee@kernel.org>
Diffstat (limited to 'drivers/mfd')
| -rw-r--r-- | drivers/mfd/macsmc.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/mfd/macsmc.c b/drivers/mfd/macsmc.c index 85410f357603..1b7e7b3e785f 100644 --- a/drivers/mfd/macsmc.c +++ b/drivers/mfd/macsmc.c @@ -416,6 +416,7 @@ static int apple_smc_probe(struct platform_device *pdev) if (!smc) return -ENOMEM; + mutex_init(&smc->mutex); smc->dev = &pdev->dev; smc->sram_base = devm_platform_get_and_ioremap_resource(pdev, 1, &smc->sram); if (IS_ERR(smc->sram_base)) |