summaryrefslogtreecommitdiff
path: root/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c
diff options
context:
space:
mode:
Diffstat (limited to 'drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c')
-rw-r--r--drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c50
1 files changed, 14 insertions, 36 deletions
diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c
index 0b8a86afb096..e8aea905fb10 100644
--- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c
+++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c
@@ -69,27 +69,24 @@ static int atmel_hlcdc_attach_endpoint(struct drm_device *dev, int endpoint)
{
struct atmel_hlcdc_rgb_output *output;
struct device_node *ep;
- struct drm_panel *panel;
struct drm_bridge *bridge;
- int ret;
+ struct atmel_hlcdc_dc *dc = dev->dev_private;
+ struct drm_crtc *crtc = dc->crtc;
+ int ret = 0;
+
+ bridge = devm_drm_of_get_bridge(dev->dev, dev->dev->of_node, 0, endpoint);
+ if (IS_ERR(bridge))
+ return PTR_ERR(bridge);
+
+ output = drmm_simple_encoder_alloc(dev, struct atmel_hlcdc_rgb_output,
+ encoder, DRM_MODE_ENCODER_NONE);
+ if (IS_ERR(output))
+ return PTR_ERR(output);
ep = of_graph_get_endpoint_by_regs(dev->dev->of_node, 0, endpoint);
if (!ep)
return -ENODEV;
- ret = drm_of_find_panel_or_bridge(dev->dev->of_node, 0, endpoint,
- &panel, &bridge);
- if (ret) {
- of_node_put(ep);
- return ret;
- }
-
- output = devm_kzalloc(dev->dev, sizeof(*output), GFP_KERNEL);
- if (!output) {
- of_node_put(ep);
- return -ENOMEM;
- }
-
output->bus_fmt = atmel_hlcdc_of_bus_fmt(ep);
of_node_put(ep);
if (output->bus_fmt < 0) {
@@ -97,30 +94,11 @@ static int atmel_hlcdc_attach_endpoint(struct drm_device *dev, int endpoint)
return -EINVAL;
}
- ret = drm_simple_encoder_init(dev, &output->encoder,
- DRM_MODE_ENCODER_NONE);
- if (ret)
- return ret;
- output->encoder.possible_crtcs = 0x1;
-
- if (panel) {
- bridge = drm_panel_bridge_add_typed(panel,
- DRM_MODE_CONNECTOR_Unknown);
- if (IS_ERR(bridge))
- return PTR_ERR(bridge);
- }
+ output->encoder.possible_crtcs = drm_crtc_mask(crtc);
- if (bridge) {
+ if (bridge)
ret = drm_bridge_attach(&output->encoder, bridge, NULL, 0);
- if (!ret)
- return 0;
-
- if (panel)
- drm_panel_bridge_remove(bridge);
- }
-
- drm_encoder_cleanup(&output->encoder);
return ret;
}